fix(swarm): poll handler after injecting LocalProtocolsChange event#3979
Merged
mergify[bot] merged 2 commits intomasterfrom May 24, 2023
Merged
fix(swarm): poll handler after injecting LocalProtocolsChange event#3979mergify[bot] merged 2 commits intomasterfrom
LocalProtocolsChange event#3979mergify[bot] merged 2 commits intomasterfrom
Conversation
4 tasks
mxinden
approved these changes
May 24, 2023
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Good catch!
Yep, no changelog entry needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, we would not call the handler upon injecting
ConnectionEvent::LocalProtocolsChange. This would prevent protocols from being able to react to this change and e.g. issue events or open streams.Notes & open questions
I decided to not add a changelog entry because this is a bug-fix for a yet-to-be-released feature.
Change checklist